Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER workarounds #79035

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Nov 30, 2022

This workaround is no longer needed with .NET SDK 7 GA

This workaround is no longer needed with .NET SDK 7 GA
@jkotas jkotas requested a review from radical as a code owner November 30, 2022 13:56
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Nov 30, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This workaround is no longer needed with .NET SDK 7 GA

Author: jkotas
Assignees: jkotas
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the one file under eng/common. Please also submit a patch in arcade for that.

@jkotas
Copy link
Member Author

jkotas commented Nov 30, 2022

Arcade PR: dotnet/arcade#11766

@radical
Copy link
Member

radical commented Nov 30, 2022

IIUC, this can't be merged till we move to building with 7.0.

@jkotas
Copy link
Member Author

jkotas commented Nov 30, 2022

#78034 moved us to building with .NET 7 GA. @radical Are there any other places where we still depend on .NET 7 previews?

@radical
Copy link
Member

radical commented Nov 30, 2022

#78034 moved us to building with .NET 7 GA. @radical Are there any other places where we still depend on .NET 7 previews?

oops, no, I'm slow!

@radical
Copy link
Member

radical commented Nov 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Nov 30, 2022

Known failures according to the build analysis

@jkotas jkotas merged commit 8cc8392 into dotnet:main Nov 30, 2022
@jkotas jkotas deleted the msbuild-server branch November 30, 2022 20:56
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants